From 10ed32c114fd24018790e92dfdf30932909a80a2 Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Thu, 22 Jul 2021 11:09:28 +0200 Subject: [PATCH] do not require generic frame descriptor extension for FrameEncryptor as there are encryption schemes that preserve the payload structure well enough and do not require those extensions. This improves consistency as the webrtc-encoded-transform API (which does not use this synchronous codepath) does not require those header extensions either. BUG=webrtc:12995 Change-Id: If237ca5d92e8871ac71c3d48fdd05127206395e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226741 Reviewed-by: Harald Alvestrand Reviewed-by: Danil Chapovalov Commit-Queue: Harald Alvestrand Cr-Commit-Position: refs/heads/master@{#34537} --- modules/rtp_rtcp/source/rtp_sender_video.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/modules/rtp_rtcp/source/rtp_sender_video.cc b/modules/rtp_rtcp/source/rtp_sender_video.cc index 4919e3ebf4..bb9080ff69 100644 --- a/modules/rtp_rtcp/source/rtp_sender_video.cc +++ b/modules/rtp_rtcp/source/rtp_sender_video.cc @@ -581,10 +581,6 @@ bool RTPSenderVideo::SendVideo( // TODO(benwright@webrtc.org) - Allocate enough to always encrypt inline. rtc::Buffer encrypted_video_payload; if (frame_encryptor_ != nullptr) { - if (!has_generic_descriptor) { - return false; - } - const size_t max_ciphertext_size = frame_encryptor_->GetMaxCiphertextByteSize(cricket::MEDIA_TYPE_VIDEO, payload.size());