admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated AudioMixerImpl creation method.

Browse Source 
AudioMixerImpl::CreateWithOutputRateCalculator has become
deprecated. Instead, either Create() or Create(OutputRateCalculator,
bool use_limiter) should be used. The first uses sensible default
values for missing arguments. The second takes all arguments. The old
CreateWithOutputRateCalculator is deprecated so that we don't have
different Create:s with all possible combinations of parameters.

Note that the factory methods may change in the future. The reason for
adding 'use_limiter' was that the limiter that was used had
questionable benefit and was very computationally expensive. Now work
is going on to replace it with a much cheaper version. After
the change, the factory method may change again to not allow for
disabling the limiter.

Bug: webrtc:7167
Change-Id: I0f9005e27e726fa552ee38dcbe965274e5006544
Reviewed-on: https://chromium-review.googlesource.com/528074
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18496}
This commit is contained in:
Alex Loiko 2017-06-08 11:32:18 +02:00 committed by Commit Bot
parent d0244c21cd
commit 1066b1379d
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_mixer/audio_mixer_impl.cc
View File

@ -118,12 +118,6 @@ rtc::scoped_refptr<AudioMixerImpl> AudioMixerImpl::Create() {
true);
}
rtc::scoped_refptr<AudioMixerImpl>
AudioMixerImpl::CreateWithOutputRateCalculator(
std::unique_ptr<OutputRateCalculator> output_rate_calculator) {
return Create(std::move(output_rate_calculator), true);
}
rtc::scoped_refptr<AudioMixerImpl> AudioMixerImpl::Create(
std::unique_ptr<OutputRateCalculator> output_rate_calculator,
bool use_limiter) {

6
webrtc/modules/audio_mixer/audio_mixer_impl.h
View File

@ -49,12 +49,6 @@ class AudioMixerImpl : public AudioMixer {
static rtc::scoped_refptr<AudioMixerImpl> Create();
// TODO(aleloi): remove this when dependencies have updated to
// use Create(rate_calculator, limiter) instead. See bugs.webrtc.org/7167.
RTC_DEPRECATED static rtc::scoped_refptr<AudioMixerImpl>
CreateWithOutputRateCalculator(
std::unique_ptr<OutputRateCalculator> output_rate_calculator);
static rtc::scoped_refptr<AudioMixerImpl> Create(
std::unique_ptr<OutputRateCalculator> output_rate_calculator,
bool use_limiter);