admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare codec number of channels and clockrate in MatchesRtpCodec for RTX too

Browse Source 
This should be a no-op since RTX is only supported for video which
has one channel and uses a clockrate of 90000.

Parameters are not compared for RTX since the RTX capabilities do not
include the associated payload type (apt).

BUG=webrtc:15847

Change-Id: Ibe6677135ecc56cdc5f3d3ccdc2e680dd449f66f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339801
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41769}
This commit is contained in:
Philipp Hancke 2024-02-15 11:24:34 +01:00 committed by WebRTC LUCI CQ
parent 41c44cde41
commit 0e9b8fe22b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
media/base/codec.cc
View File

@ -243,10 +243,10 @@ bool Codec::MatchesRtpCodec(const webrtc::RtpCodec& codec_capability) const {
return codec_parameters.name == codec_capability.name && return codec_parameters.name == codec_capability.name &&
codec_parameters.kind == codec_capability.kind && codec_parameters.kind == codec_capability.kind &&
codec_parameters.num_channels == codec_capability.num_channels &&
codec_parameters.clock_rate == codec_capability.clock_rate &&
(codec_parameters.name == cricket::kRtxCodecName || (codec_parameters.name == cricket::kRtxCodecName ||
(codec_parameters.num_channels == codec_capability.num_channels && codec_parameters.parameters == codec_capability.parameters);
codec_parameters.clock_rate == codec_capability.clock_rate &&
codec_parameters.parameters == codec_capability.parameters));
} }
bool Codec::GetParam(const std::string& name, std::string* out) const { bool Codec::GetParam(const std::string& name, std::string* out) const {