From 0cf208aa28ed3c1b7a0425c96f2fdf8ac29eb25d Mon Sep 17 00:00:00 2001 From: thakis Date: Wed, 6 Jul 2016 10:46:41 -0700 Subject: [PATCH] mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true Review-Url: https://codereview.webrtc.org/2117823002 Cr-Commit-Position: refs/heads/master@{#13399} --- webrtc/base/macutils.cc | 2 +- webrtc/base/macutils.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/webrtc/base/macutils.cc b/webrtc/base/macutils.cc index 74b4919964..72ca5cb349 100644 --- a/webrtc/base/macutils.cc +++ b/webrtc/base/macutils.cc @@ -83,7 +83,7 @@ static bool GetGestalt(OSType ostype, int* value) { return false; } -bool GetOSVersion(int* major, int* minor, int* bugfix) { +static bool GetOSVersion(int* major, int* minor, int* bugfix) { ASSERT(major && minor && bugfix); if (!GetGestalt(gestaltSystemVersion, major)) { return false; diff --git a/webrtc/base/macutils.h b/webrtc/base/macutils.h index 35c3d1870b..e3a42563d2 100644 --- a/webrtc/base/macutils.h +++ b/webrtc/base/macutils.h @@ -43,7 +43,6 @@ enum MacOSVersionName { kMacOSNewer, // 10.10+ }; -bool GetOSVersion(int* major, int* minor, int* bugfix); MacOSVersionName GetOSVersionName(); bool GetQuickTimeVersion(std::string* version);