From 0cc11b4b947e0ceae14e717aa25ceffc480529a3 Mon Sep 17 00:00:00 2001 From: Magnus Jedvert Date: Tue, 27 Nov 2018 16:19:55 +0100 Subject: [PATCH] Android: Bump stack trace logging severity from debug to warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Stack traces usually get printed when an error occur and we want this to be included in release versions. Bug: None Change-Id: I17fdbc58393f5b4d597b14e95240bdb04473b4ad Reviewed-on: https://webrtc-review.googlesource.com/c/112133 Commit-Queue: Sami Kalliomäki Reviewed-by: Sami Kalliomäki Cr-Commit-Position: refs/heads/master@{#25821} --- sdk/android/api/org/webrtc/EglRenderer.java | 8 ++++++-- sdk/android/api/org/webrtc/PeerConnectionFactory.java | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/sdk/android/api/org/webrtc/EglRenderer.java b/sdk/android/api/org/webrtc/EglRenderer.java index e810053003..42a07c029a 100644 --- a/sdk/android/api/org/webrtc/EglRenderer.java +++ b/sdk/android/api/org/webrtc/EglRenderer.java @@ -330,9 +330,9 @@ public class EglRenderer implements VideoSink { if (renderThread != null) { final StackTraceElement[] renderStackTrace = renderThread.getStackTrace(); if (renderStackTrace.length > 0) { - logD("EglRenderer stack trace:"); + logW("EglRenderer stack trace:"); for (StackTraceElement traceElem : renderStackTrace) { - logD(traceElem.toString()); + logW(traceElem.toString()); } } } @@ -729,4 +729,8 @@ public class EglRenderer implements VideoSink { private void logD(String string) { Logging.d(TAG, name + string); } + + private void logW(String string) { + Logging.w(TAG, name + string); + } } diff --git a/sdk/android/api/org/webrtc/PeerConnectionFactory.java b/sdk/android/api/org/webrtc/PeerConnectionFactory.java index 018fb76e85..f5d1ee1361 100644 --- a/sdk/android/api/org/webrtc/PeerConnectionFactory.java +++ b/sdk/android/api/org/webrtc/PeerConnectionFactory.java @@ -490,9 +490,9 @@ public class PeerConnectionFactory { if (thread != null) { StackTraceElement[] stackTraces = thread.getStackTrace(); if (stackTraces.length > 0) { - Logging.d(TAG, threadName + " stacks trace:"); + Logging.w(TAG, threadName + " stacks trace:"); for (StackTraceElement stackTrace : stackTraces) { - Logging.d(TAG, stackTrace.toString()); + Logging.w(TAG, stackTrace.toString()); } } }