From 0c011d9499deb10b3a3d15dd7a3c52b07babeacd Mon Sep 17 00:00:00 2001 From: philipel Date: Tue, 12 Sep 2017 05:13:53 -0700 Subject: [PATCH] Make sure send and receive deltas are positive for remote estimated probe clusters. BUG=b/65531353 Review-Url: https://codereview.webrtc.org/3005393002 Cr-Commit-Position: refs/heads/master@{#19796} --- .../remote_bitrate_estimator_abs_send_time.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc index d3dcfca6e0..c43bc12a4a 100644 --- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc +++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc @@ -111,8 +111,11 @@ void RemoteBitrateEstimatorAbsSendTime::ComputeClusters( ++current.num_above_min_delta; } if (!IsWithinClusterBounds(send_delta_ms, current)) { - if (current.count >= kMinClusterSize) + if (current.count >= kMinClusterSize && + current.send_mean_ms > 0.0f && + current.recv_mean_ms > 0.0f) { AddCluster(clusters, ¤t); + } current = Cluster(); } current.send_mean_ms += send_delta_ms; @@ -123,8 +126,11 @@ void RemoteBitrateEstimatorAbsSendTime::ComputeClusters( prev_send_time = it->send_time_ms; prev_recv_time = it->recv_time_ms; } - if (current.count >= kMinClusterSize) + if (current.count >= kMinClusterSize && + current.send_mean_ms > 0.0f && + current.recv_mean_ms > 0.0f) { AddCluster(clusters, ¤t); + } } std::list::const_iterator