From 0a6e0dc471a90229c4f9a5a876e4ffafc4233c97 Mon Sep 17 00:00:00 2001 From: stefan Date: Thu, 15 Sep 2016 05:04:34 -0700 Subject: [PATCH] Disable all screen-capturer tests ScreenCapturerTest.CaptureUpdatedRegion* tests are flaky and are running in the wrong executable. BUG=webrtc:6366, chromium:647067 NOTRY=True Review-Url: https://codereview.webrtc.org/2342823002 Cr-Commit-Position: refs/heads/master@{#14232} --- .../screen_capturer_unittest.cc | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/webrtc/modules/desktop_capture/screen_capturer_unittest.cc b/webrtc/modules/desktop_capture/screen_capturer_unittest.cc index cb639b9e91..0236e3b668 100644 --- a/webrtc/modules/desktop_capture/screen_capturer_unittest.cc +++ b/webrtc/modules/desktop_capture/screen_capturer_unittest.cc @@ -271,10 +271,14 @@ TEST_F(ScreenCapturerTest, Capture) { EXPECT_TRUE(it.IsAtEnd()); } -TEST_F(ScreenCapturerTest, CaptureUpdatedRegion) { +// Disabled due to being flaky due to the fact that it useds rendering / UI, +// see webrtc/6366. +TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegion) { TestCaptureUpdatedRegion(); } +// Disabled due to being flaky due to the fact that it useds rendering / UI, +// see webrtc/6366. // TODO(zijiehe): Find out the reason of failure of this test on trybot. TEST_F(ScreenCapturerTest, DISABLED_TwoCapturers) { std::unique_ptr capturer2 = std::move(capturer_); @@ -347,7 +351,9 @@ TEST_F(ScreenCapturerTest, UseDirectxCapturerWithSharedBuffers) { EXPECT_EQ(frame->shared_memory()->id(), kTestSharedMemoryId); } -TEST_F(ScreenCapturerTest, CaptureUpdatedRegionWithDirectxCapturer) { +// Disabled due to being flaky due to the fact that it useds rendering / UI, +// see webrtc/6366. +TEST_F(ScreenCapturerTest, DISABLED_CaptureUpdatedRegionWithDirectxCapturer) { if (!CreateDirectxCapturer()) { return; } @@ -355,7 +361,9 @@ TEST_F(ScreenCapturerTest, CaptureUpdatedRegionWithDirectxCapturer) { TestCaptureUpdatedRegion(); } -TEST_F(ScreenCapturerTest, TwoDirectxCapturers) { +// Disabled due to being flaky due to the fact that it useds rendering / UI, +// see webrtc/6366. +TEST_F(ScreenCapturerTest, DISABLED_TwoDirectxCapturers) { if (!CreateDirectxCapturer()) { return; } @@ -365,7 +373,9 @@ TEST_F(ScreenCapturerTest, TwoDirectxCapturers) { TestCaptureUpdatedRegion({capturer_.get(), capturer2.get()}); } -TEST_F(ScreenCapturerTest, TwoMagnifierCapturers) { +// Disabled due to being flaky due to the fact that it useds rendering / UI, +// see webrtc/6366. +TEST_F(ScreenCapturerTest, DISABLED_TwoMagnifierCapturers) { CreateMagnifierCapturer(); std::unique_ptr capturer2 = std::move(capturer_); CreateMagnifierCapturer();