admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dependency on system_wrappers from rtc_event_log.

Browse Source 
Bug: webrtc:8111
Change-Id: Id9e2503b153bc7172e7a5e92f6becc791da0aadf
Reviewed-on: https://webrtc-review.googlesource.com/41261
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21698}
This commit is contained in:
Bjorn Terelius 2018-01-19 17:52:38 +01:00 committed by Commit Bot
parent 1a6793a35b
commit 0a6a2b73a1
4 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
logging/BUILD.gn
View File

@ -79,7 +79,6 @@ rtc_source_set("rtc_event_log_api") {
"../modules/rtp_rtcp:rtp_rtcp_format",
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../system_wrappers",
]
# TODO(eladalon): Remove this.
@ -113,7 +112,6 @@ rtc_static_library("rtc_event_log_impl") {
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_task_queue",
"../rtc_base:sequenced_task_checker",
"../system_wrappers",
]
if (rtc_enable_protobuf) {
@ -162,7 +160,6 @@ if (rtc_enable_protobuf) {
"../rtc_base:checks",
"../rtc_base:protobuf_utils",
"../rtc_base:rtc_base_approved",
"../system_wrappers",
]
if (!build_with_chromium && is_clang) {
@ -200,7 +197,6 @@ if (rtc_enable_protobuf) {
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_base_tests_utils",
"../system_wrappers:metrics_default",
"../test:test_support",
"//testing/gmock",
"//testing/gtest",

1
logging/rtc_event_log/DEPS
View File

@ -3,5 +3,4 @@ include_rules = [
"+modules/audio_coding/audio_network_adaptor",
"+modules/remote_bitrate_estimator/include",
"+modules/rtp_rtcp",
"+system_wrappers",
]

9
logging/rtc_event_log/rtc_event_log.h
View File

@ -20,8 +20,6 @@
namespace webrtc {
class Clock;
enum PacketDirection { kIncomingPacket = 0, kOutgoingPacket };
class RtcEventLog {
@ -38,13 +36,6 @@ class RtcEventLog {
// Factory method to create an RtcEventLog object.
static std::unique_ptr<RtcEventLog> Create(EncodingType encoding_type);
// TODO(nisse): webrtc::Clock is deprecated. Delete this method and
// above forward declaration of Clock when
// webrtc/system_wrappers/include/clock.h is deleted.
static std::unique_ptr<RtcEventLog> Create(const Clock* clock,
EncodingType encoding_type) {
return Create(encoding_type);
}
// Create an RtcEventLog object that does nothing.
static std::unique_ptr<RtcEventLog> CreateNull();

6
video/video_quality_test.cc
View File

@ -1834,10 +1834,8 @@ void VideoQualityTest::RunWithAnalyzer(const Params& params) {
}
if (!params.logging.rtc_event_log_name.empty()) {
send_event_log_ =
RtcEventLog::Create(clock_, RtcEventLog::EncodingType::Legacy);
recv_event_log_ =
RtcEventLog::Create(clock_, RtcEventLog::EncodingType::Legacy);
send_event_log_ = RtcEventLog::Create(RtcEventLog::EncodingType::Legacy);
recv_event_log_ = RtcEventLog::Create(RtcEventLog::EncodingType::Legacy);
std::unique_ptr<RtcEventLogOutputFile> send_output(
rtc::MakeUnique<RtcEventLogOutputFile>(
params.logging.rtc_event_log_name + "_send",