From 09f119598e4980b9ec35db5060a2560ad4684338 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Sun, 29 Sep 2019 10:19:42 +0200 Subject: [PATCH] Always pass arguments to INSTANTIATE_TEST_SUITE_P. Passing an empty arg is working at the moment but it is not guaranteed to continue to work in the future. Bug: None Change-Id: I975bc8779bac9700854de411301415338dcaf9f6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154820 Reviewed-by: Stefan Holmer Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29343} --- common_video/h264/sps_vui_rewriter_unittest.cc | 2 +- media/engine/webrtc_video_engine_unittest.cc | 2 +- video/quality_limitation_reason_tracker_unittest.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common_video/h264/sps_vui_rewriter_unittest.cc b/common_video/h264/sps_vui_rewriter_unittest.cc index 6ec6dead05..e008948ce1 100644 --- a/common_video/h264/sps_vui_rewriter_unittest.cc +++ b/common_video/h264/sps_vui_rewriter_unittest.cc @@ -349,7 +349,7 @@ TEST_P(SpsVuiRewriterTest, RewriteVui) { } INSTANTIATE_TEST_SUITE_P( - , + All, SpsVuiRewriterTest, ::testing::Values( std::make_tuple(kVuiNoFrameBuffering, diff --git a/media/engine/webrtc_video_engine_unittest.cc b/media/engine/webrtc_video_engine_unittest.cc index 98a0d9dd57..ca2d1a2344 100644 --- a/media/engine/webrtc_video_engine_unittest.cc +++ b/media/engine/webrtc_video_engine_unittest.cc @@ -3450,7 +3450,7 @@ TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) { } INSTANTIATE_TEST_SUITE_P( - , + All, Vp9SettingsTestWithFieldTrial, ::testing::Values( std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic), diff --git a/video/quality_limitation_reason_tracker_unittest.cc b/video/quality_limitation_reason_tracker_unittest.cc index 9756b36573..c394535974 100644 --- a/video/quality_limitation_reason_tracker_unittest.cc +++ b/video/quality_limitation_reason_tracker_unittest.cc @@ -105,7 +105,7 @@ TEST_P(QualityLimitationReasonTrackerTestWithParamReason, } INSTANTIATE_TEST_SUITE_P( - , + All, QualityLimitationReasonTrackerTestWithParamReason, ::testing::Values(QualityLimitationReason::kNone, // "/0" QualityLimitationReason::kCpu, // "/1"