From 09dcafdd212777f109378cc98db797e15c2d2513 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 4 Sep 2019 18:19:02 +0000 Subject: [PATCH] Revert "Always create output_dir in setup_apprtc.py." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 52a8da38f9ec6da7c487626c699d811e542e1cf5. Reason for revert: It doesn't solve the problem. Original change's description: > Always create output_dir in setup_apprtc.py. > > This should probably fix [1]. It only happens on Windows bots and from > the error it looks like if output_dir is missing, the unzipping just > fails. > > [1] - https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4027 > > Bug: None > Change-Id: I2f0abe90898d6d15525b46fd74635e2a3150cb37 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151307 > Reviewed-by: Patrik Höglund > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#29064} TBR=phoglund@webrtc.org,mbonadei@webrtc.org Change-Id: If8d93033dcb871476f23c1597f24efcd2e20cfb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151420 Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29067} --- rtc_tools/testing/setup_apprtc.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/rtc_tools/testing/setup_apprtc.py b/rtc_tools/testing/setup_apprtc.py index 749ed254c8..2b463e004d 100755 --- a/rtc_tools/testing/setup_apprtc.py +++ b/rtc_tools/testing/setup_apprtc.py @@ -29,9 +29,6 @@ def main(argv): output_dir = os.path.abspath(argv[1]) - if not os.path.exists(output_dir): - os.makedirs(output_dir) - download_apprtc_path = os.path.join(SCRIPT_DIR, 'download_apprtc.py') utils.RunSubprocessWithRetry([sys.executable, download_apprtc_path, output_dir])