diff --git a/webrtc/voice_engine/include/voe_base.h b/webrtc/voice_engine/include/voe_base.h index 28f465e6d2..b26f73a989 100644 --- a/webrtc/voice_engine/include/voe_base.h +++ b/webrtc/voice_engine/include/voe_base.h @@ -86,7 +86,7 @@ public: protected: VoiceEngine() {} - virtual ~VoiceEngine() {} + ~VoiceEngine() {} }; // VoEBase diff --git a/webrtc/voice_engine/voe_audio_processing_impl.cc b/webrtc/voice_engine/voe_audio_processing_impl.cc index 9397bfaf08..a9780f2776 100644 --- a/webrtc/voice_engine/voe_audio_processing_impl.cc +++ b/webrtc/voice_engine/voe_audio_processing_impl.cc @@ -51,7 +51,7 @@ VoEAudioProcessing* VoEAudioProcessing::GetInterface(VoiceEngine* voiceEngine) { if (NULL == voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_base_impl.cc b/webrtc/voice_engine/voe_base_impl.cc index b63564639e..28eb35cda9 100644 --- a/webrtc/voice_engine/voe_base_impl.cc +++ b/webrtc/voice_engine/voe_base_impl.cc @@ -40,7 +40,7 @@ VoEBase* VoEBase::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; } diff --git a/webrtc/voice_engine/voe_call_report_impl.cc b/webrtc/voice_engine/voe_call_report_impl.cc index 778cb816bf..c4a6bc9198 100644 --- a/webrtc/voice_engine/voe_call_report_impl.cc +++ b/webrtc/voice_engine/voe_call_report_impl.cc @@ -30,7 +30,7 @@ VoECallReport* VoECallReport::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_codec_impl.cc b/webrtc/voice_engine/voe_codec_impl.cc index 993e7bdf53..4768004a20 100644 --- a/webrtc/voice_engine/voe_codec_impl.cc +++ b/webrtc/voice_engine/voe_codec_impl.cc @@ -29,7 +29,7 @@ VoECodec* VoECodec::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_dtmf_impl.cc b/webrtc/voice_engine/voe_dtmf_impl.cc index 05817378ff..5353cf413e 100644 --- a/webrtc/voice_engine/voe_dtmf_impl.cc +++ b/webrtc/voice_engine/voe_dtmf_impl.cc @@ -29,7 +29,7 @@ VoEDtmf* VoEDtmf::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_encryption_impl.cc b/webrtc/voice_engine/voe_encryption_impl.cc index 4ac8ada53c..4dbed0a692 100644 --- a/webrtc/voice_engine/voe_encryption_impl.cc +++ b/webrtc/voice_engine/voe_encryption_impl.cc @@ -28,7 +28,7 @@ VoEEncryption* VoEEncryption::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_external_media_impl.cc b/webrtc/voice_engine/voe_external_media_impl.cc index 12c75cb587..c8550c8454 100644 --- a/webrtc/voice_engine/voe_external_media_impl.cc +++ b/webrtc/voice_engine/voe_external_media_impl.cc @@ -29,7 +29,7 @@ VoEExternalMedia* VoEExternalMedia::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_file_impl.cc b/webrtc/voice_engine/voe_file_impl.cc index 869cd8640b..1dda43fda0 100644 --- a/webrtc/voice_engine/voe_file_impl.cc +++ b/webrtc/voice_engine/voe_file_impl.cc @@ -31,7 +31,7 @@ VoEFile* VoEFile::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_hardware_impl.cc b/webrtc/voice_engine/voe_hardware_impl.cc index 99e65cc4d0..db7e18fa82 100644 --- a/webrtc/voice_engine/voe_hardware_impl.cc +++ b/webrtc/voice_engine/voe_hardware_impl.cc @@ -30,7 +30,7 @@ VoEHardware* VoEHardware::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_neteq_stats_impl.cc b/webrtc/voice_engine/voe_neteq_stats_impl.cc index 50f2dfbd77..94966cb8d8 100644 --- a/webrtc/voice_engine/voe_neteq_stats_impl.cc +++ b/webrtc/voice_engine/voe_neteq_stats_impl.cc @@ -29,7 +29,7 @@ VoENetEqStats* VoENetEqStats::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_network_impl.cc b/webrtc/voice_engine/voe_network_impl.cc index d0b9895c70..c5639008ac 100644 --- a/webrtc/voice_engine/voe_network_impl.cc +++ b/webrtc/voice_engine/voe_network_impl.cc @@ -28,7 +28,7 @@ VoENetwork* VoENetwork::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_rtp_rtcp_impl.cc b/webrtc/voice_engine/voe_rtp_rtcp_impl.cc index 0414ecdac4..3470443c29 100644 --- a/webrtc/voice_engine/voe_rtp_rtcp_impl.cc +++ b/webrtc/voice_engine/voe_rtp_rtcp_impl.cc @@ -29,7 +29,7 @@ VoERTP_RTCP* VoERTP_RTCP::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_video_sync_impl.cc b/webrtc/voice_engine/voe_video_sync_impl.cc index b0910c318c..7df460312f 100644 --- a/webrtc/voice_engine/voe_video_sync_impl.cc +++ b/webrtc/voice_engine/voe_video_sync_impl.cc @@ -27,7 +27,7 @@ VoEVideoSync* VoEVideoSync::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voe_volume_control_impl.cc b/webrtc/voice_engine/voe_volume_control_impl.cc index f0d165217a..3d55c7f310 100644 --- a/webrtc/voice_engine/voe_volume_control_impl.cc +++ b/webrtc/voice_engine/voe_volume_control_impl.cc @@ -29,7 +29,7 @@ VoEVolumeControl* VoEVolumeControl::GetInterface(VoiceEngine* voiceEngine) { return NULL; } - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); s->AddRef(); return s; #endif diff --git a/webrtc/voice_engine/voice_engine_impl.cc b/webrtc/voice_engine/voice_engine_impl.cc index 18f841c296..affd1a8d64 100644 --- a/webrtc/voice_engine/voice_engine_impl.cc +++ b/webrtc/voice_engine/voice_engine_impl.cc @@ -31,13 +31,12 @@ WEBRTC_DLLEXPORT VoiceEngine* GetVoiceEngine(); VoiceEngine* GetVoiceEngine() { VoiceEngineImpl* self = new VoiceEngineImpl(); - VoiceEngine* ve = reinterpret_cast(self); - if (ve != NULL) + if (self != NULL) { self->AddRef(); // First reference. Released in VoiceEngine::Delete. gVoiceEngineInstanceCounter++; } - return ve; + return self; } } // extern "C" @@ -128,7 +127,7 @@ bool VoiceEngine::Delete(VoiceEngine*& voiceEngine) if (voiceEngine == NULL) return false; - VoiceEngineImpl* s = reinterpret_cast(voiceEngine); + VoiceEngineImpl* s = static_cast(voiceEngine); // Release the reference that was added in GetVoiceEngine. int ref = s->Release(); voiceEngine = NULL; diff --git a/webrtc/voice_engine/voice_engine_impl.h b/webrtc/voice_engine/voice_engine_impl.h index 7db77be6e8..2b3963cdf2 100644 --- a/webrtc/voice_engine/voice_engine_impl.h +++ b/webrtc/voice_engine/voice_engine_impl.h @@ -59,6 +59,7 @@ namespace webrtc { class VoiceEngineImpl : public voe::SharedData, // Must be the first base class + public VoiceEngine, #ifdef WEBRTC_VOICE_ENGINE_AUDIO_PROCESSING_API public VoEAudioProcessingImpl, #endif