From 06f6bc9ec4739331640a7532ea3b1432052814f0 Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Fri, 9 Nov 2018 10:22:52 +0100 Subject: [PATCH] Reintroduce missing dependencies in libwebrtc.a library. Some targets used to be included transitively via ortc. Since ortc module has been removed (Bug: webrtc:9824), this CL explicitly add them in main //:webrtc target. As a result, the following functions are exposed again: CreateBuiltinVideoDecoderFactory() CreateBuiltinVideoEncoderFactory() CreatePeerConnectionFactory() [...] Bug: webrtc:9824 Bug: webrtc:9973 Change-Id: Iebfae582f8887bf76338c73fc85c4608e96c3f0d Reviewed-on: https://webrtc-review.googlesource.com/c/110248 Commit-Queue: Yves Gerey Reviewed-by: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#25576} --- BUILD.gn | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 3a89edcd9a..c67602cb57 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -379,28 +379,33 @@ if (!build_with_chromium) { deps = [ ":webrtc_common", + "api:libjingle_peerconnection_api", "api:transport_api", "audio", "call", "common_audio", "common_video", + "logging:rtc_event_log_api", + "logging:rtc_event_log_impl_base", "media", "modules", "modules/video_capture:video_capture_internal_impl", + "p2p:rtc_p2p", + "pc:libjingle_peerconnection", + "pc:peerconnection", + "pc:rtc_pc", + "pc:rtc_pc_base", "rtc_base", "sdk", "video", ] - # Additional factory functions to be exposed. - # Rational: These factories are small enough (89 KiB / 32+ MiB) - # to be unconditionaly included for user convenience. - # That begin said: - # TODO(yvesg) Consider making all non-core APIs optional, so that users - # can build a customized library tailored to their needs. + # Include audio and video codecs by default. deps += [ "api/audio_codecs:builtin_audio_decoder_factory", "api/audio_codecs:builtin_audio_encoder_factory", + "api/video_codecs:builtin_video_decoder_factory", + "api/video_codecs:builtin_video_encoder_factory", ] if (build_with_mozilla) {