From 06c944f0353d1885d4a1661a16a20e907f6e9c0b Mon Sep 17 00:00:00 2001 From: Gustaf Ullberg Date: Wed, 31 Jan 2018 20:16:38 +0100 Subject: [PATCH] Fix aecdumps in AppRTC on Android. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL fixes an issue where the aecdump file handle gets garbage collected and closed early in the call. Bug: webrtc:8822 Change-Id: I959908da164b0ec61ccd976fc52f3d919da11b52 Reviewed-on: https://webrtc-review.googlesource.com/46103 Reviewed-by: Sami Kalliomäki Commit-Queue: Gustaf Ullberg Cr-Commit-Position: refs/heads/master@{#21839} --- .../androidapp/src/org/appspot/apprtc/PeerConnectionClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java b/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java index 74b4edab90..a7489b9320 100644 --- a/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java +++ b/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java @@ -659,7 +659,7 @@ public class PeerConnectionClient { + File.separator + "Download/audio.aecdump"), ParcelFileDescriptor.MODE_READ_WRITE | ParcelFileDescriptor.MODE_CREATE | ParcelFileDescriptor.MODE_TRUNCATE); - factory.startAecDump(aecDumpFileDescriptor.getFd(), -1); + factory.startAecDump(aecDumpFileDescriptor.detachFd(), -1); } catch (IOException e) { Log.e(TAG, "Can not open aecdump file", e); }