admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make WebRTC-EventLogNewFormat default.

Browse Source 
This makes WebRTC-EventLogNewFormat the default Event logging format.

Bug: chromium:1433664
Change-Id: Ic35d7ed0e88b0cbe7af3003007a4e21d9b349a64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/310480
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Lionel Koenig <lionelk@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40358}
This commit is contained in:
Lionel Koenig 2023-06-27 08:46:19 +00:00 committed by WebRTC LUCI CQ
parent 299cdc9057
commit 0606eafb9f
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pc/peer_connection.cc
View File

@ -1780,9 +1780,9 @@ bool PeerConnection::StartRtcEventLog(std::unique_ptr<RtcEventLogOutput> output,
bool PeerConnection::StartRtcEventLog( bool PeerConnection::StartRtcEventLog(
std::unique_ptr<RtcEventLogOutput> output) { std::unique_ptr<RtcEventLogOutput> output) {
int64_t output_period_ms = webrtc::RtcEventLog::kImmediateOutput; int64_t output_period_ms = 5000;
if (trials().IsEnabled("WebRTC-RtcEventLogNewFormat")) { if (trials().IsDisabled("WebRTC-RtcEventLogNewFormat")) {
output_period_ms = 5000; output_period_ms = webrtc::RtcEventLog::kImmediateOutput;
} }
return StartRtcEventLog(std::move(output), output_period_ms); return StartRtcEventLog(std::move(output), output_period_ms);
} }

6
pc/peer_connection_factory.cc
View File

@ -293,9 +293,9 @@ rtc::scoped_refptr<AudioTrackInterface> PeerConnectionFactory::CreateAudioTrack(
std::unique_ptr<RtcEventLog> PeerConnectionFactory::CreateRtcEventLog_w() { std::unique_ptr<RtcEventLog> PeerConnectionFactory::CreateRtcEventLog_w() {
RTC_DCHECK_RUN_ON(worker_thread()); RTC_DCHECK_RUN_ON(worker_thread());
auto encoding_type = RtcEventLog::EncodingType::Legacy; auto encoding_type = RtcEventLog::EncodingType::NewFormat;
if (IsTrialEnabled("WebRTC-RtcEventLogNewFormat")) if (field_trials().IsDisabled("WebRTC-RtcEventLogNewFormat"))
encoding_type = RtcEventLog::EncodingType::NewFormat; encoding_type = RtcEventLog::EncodingType::Legacy;
return event_log_factory_ ? event_log_factory_->Create(encoding_type) return event_log_factory_ ? event_log_factory_->Create(encoding_type)
: std::make_unique<RtcEventLogNull>(); : std::make_unique<RtcEventLogNull>();
} }