From 04ed0a0773a364e7676db87396f308264cc35d7e Mon Sep 17 00:00:00 2001 From: Johannes Kron Date: Tue, 8 Dec 2020 14:47:40 +0100 Subject: [PATCH] Change LS_ERROR to LS_WARNING for unsupported decoder formats There is currently an error reported about unsupported formats for most users when an WebRTC connection is setup. This CL changes the error to a warning. The reason is that some H264 profiles are supported in hardware but not in software. When the decoder is created we will try to create pair of both software and hardware decoders for the union of supported formats. The creation of the software decoder will then fail. There is a small risk that this leads to errors later but only in rare circumstances. Most of the time this log line only confuses consumers as well as developers. Bug: none Change-Id: Ib2119016fa91bc270437a2bcf7892e9fdd7c419c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196645 Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Johannes Kron Cr-Commit-Position: refs/heads/master@{#32800} --- media/engine/internal_decoder_factory.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/media/engine/internal_decoder_factory.cc b/media/engine/internal_decoder_factory.cc index d512b731af..1c084846a2 100644 --- a/media/engine/internal_decoder_factory.cc +++ b/media/engine/internal_decoder_factory.cc @@ -56,7 +56,8 @@ std::vector InternalDecoderFactory::GetSupportedFormats() std::unique_ptr InternalDecoderFactory::CreateVideoDecoder( const SdpVideoFormat& format) { if (!IsFormatSupported(GetSupportedFormats(), format)) { - RTC_LOG(LS_ERROR) << "Trying to create decoder for unsupported format"; + RTC_LOG(LS_WARNING) << "Trying to create decoder for unsupported format. " + << format.ToString(); return nullptr; }