From 046c979cb50cc874b892e37f6a5aa390dc08d28f Mon Sep 17 00:00:00 2001 From: Andrew Grieve Date: Mon, 20 Jan 2025 11:29:38 -0500 Subject: [PATCH] Delete reference to "no_build_hooks" GN variable (part 2) It's a no-op and I'm going to remove it. Bug: chromium:40114668 Change-Id: If401cfb8218597a38f3ef45baf1ac2eb5f765cbb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/374920 Auto-Submit: Andrew Grieve Reviewed-by: Mirko Bonadei Commit-Queue: Mirko Bonadei Reviewed-by: Jeremy Leconte Cr-Commit-Position: refs/heads/main@{#43783} --- webrtc.gni | 32 +------------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/webrtc.gni b/webrtc.gni index 88e7073560..c5eeba5211 100644 --- a/webrtc.gni +++ b/webrtc.gni @@ -1210,21 +1210,11 @@ if (is_android) { "visibility", ]) - errorprone_args = [] - - # Treat warnings as errors. - errorprone_args += [ "-Werror" ] - # Add any arguments defined by the invoker. if (defined(invoker.errorprone_args)) { - errorprone_args += invoker.errorprone_args + errorprone_args = invoker.errorprone_args } - if (!defined(deps)) { - deps = [] - } - - no_build_hooks = true not_needed([ "android_manifest" ]) } } @@ -1239,16 +1229,6 @@ if (is_android) { "suppressed_configs", "visibility", ]) - - # Treat warnings as errors. - errorprone_args = [] - errorprone_args += [ "-Werror" ] - - if (!defined(deps)) { - deps = [] - } - - no_build_hooks = true } } @@ -1262,16 +1242,6 @@ if (is_android) { "suppressed_configs", "visibility", ]) - - # Treat warnings as errors. - errorprone_args = [] - errorprone_args += [ "-Werror" ] - - if (!defined(deps)) { - deps = [] - } - - no_build_hooks = true } } }