From 03df29c10038012c37bc8edd84608d69afc1e6b0 Mon Sep 17 00:00:00 2001 From: Jonathan Lennox Date: Tue, 13 Jul 2021 12:41:31 -0400 Subject: [PATCH] Add -render_width and -render_height arguments to video_replay. Bug: webrtc:12975 Change-Id: Ice8d704980a374378a1e20f526d5d8fb60e4db3f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225960 Commit-Queue: Mirko Bonadei Reviewed-by: Ilya Nikolaevskiy Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#34605} --- rtc_tools/video_replay.cc | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/rtc_tools/video_replay.cc b/rtc_tools/video_replay.cc index 62981b6b1a..02202ddba8 100644 --- a/rtc_tools/video_replay.cc +++ b/rtc_tools/video_replay.cc @@ -126,6 +126,10 @@ ABSL_FLAG(uint32_t, "RTP stop timestamp, packets with larger timestamp will be ignored " "(no wraparound)"); +// Flags for render window width and height +ABSL_FLAG(uint32_t, render_width, 640, "Width of render window"); +ABSL_FLAG(uint32_t, render_height, 480, "Height of render window"); + namespace { static bool ValidatePayloadType(int32_t payload_type) { @@ -204,6 +208,14 @@ static std::string Codec() { return absl::GetFlag(FLAGS_codec); } +static uint32_t RenderWidth() { + return absl::GetFlag(FLAGS_render_width); +} + +static uint32_t RenderHeight() { + return absl::GetFlag(FLAGS_render_height); +} + } // namespace namespace webrtc { @@ -415,8 +427,8 @@ class RtpReplayer final { // Create a window for this config. std::stringstream window_title; window_title << "Playback Video (" << config_count++ << ")"; - stream_state->sinks.emplace_back( - test::VideoRenderer::Create(window_title.str().c_str(), 640, 480)); + stream_state->sinks.emplace_back(test::VideoRenderer::Create( + window_title.str().c_str(), RenderWidth(), RenderHeight())); // Create a receive stream for this config. receive_config.renderer = stream_state->sinks.back().get(); receive_config.decoder_factory = stream_state->decoder_factory.get(); @@ -436,7 +448,8 @@ class RtpReplayer final { std::stringstream window_title; window_title << "Playback Video (" << rtp_dump_path << ")"; std::unique_ptr playback_video( - test::VideoRenderer::Create(window_title.str().c_str(), 640, 480)); + test::VideoRenderer::Create(window_title.str().c_str(), RenderWidth(), + RenderHeight())); auto file_passthrough = std::make_unique( OutBase(), playback_video.get()); stream_state->sinks.push_back(std::move(playback_video));