admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dependency on rtc::TaskQueue in AudioProcessing module

Browse Source 
Bug: webrtc:14169
Change-Id: I703cd01a6fd013ae4d5236bb76686aab4aa89381
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333960
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41551}
This commit is contained in:
Danil Chapovalov 2024-01-15 15:51:12 +01:00 committed by WebRTC LUCI CQ
parent df3b3bd06f
commit 02d9eceb3c
5 changed files with 0 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/audio_processing/BUILD.gn
View File

@ -37,7 +37,6 @@ rtc_library("api") {
"../../api/task_queue", "../../api/task_queue",
"../../rtc_base:macromagic", "../../rtc_base:macromagic",
"../../rtc_base:refcount", "../../rtc_base:refcount",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:stringutils", "../../rtc_base:stringutils",
"../../rtc_base/system:arch", "../../rtc_base/system:arch",
"../../rtc_base/system:file_wrapper", "../../rtc_base/system:file_wrapper",

1
modules/audio_processing/aec_dump/BUILD.gn
View File

@ -15,7 +15,6 @@ rtc_source_set("aec_dump") {
deps = [ deps = [
"..:aec_dump_interface", "..:aec_dump_interface",
"../../../api/task_queue", "../../../api/task_queue",
"../../../rtc_base:rtc_task_queue",
"../../../rtc_base/system:file_wrapper", "../../../rtc_base/system:file_wrapper",
"../../../rtc_base/system:rtc_export", "../../../rtc_base/system:rtc_export",
] ]

10
modules/audio_processing/aec_dump/aec_dump_factory.h
View File

@ -19,7 +19,6 @@
#include "modules/audio_processing/include/aec_dump.h" #include "modules/audio_processing/include/aec_dump.h"
#include "rtc_base/system/file_wrapper.h" #include "rtc_base/system/file_wrapper.h"
#include "rtc_base/system/rtc_export.h" #include "rtc_base/system/rtc_export.h"
#include "rtc_base/task_queue.h"
namespace webrtc { namespace webrtc {
@ -42,15 +41,6 @@ class RTC_EXPORT AecDumpFactory {
absl::Nonnull<FILE*> handle, absl::Nonnull<FILE*> handle,
int64_t max_log_size_bytes, int64_t max_log_size_bytes,
absl::Nonnull<TaskQueueBase*> worker_queue); absl::Nonnull<TaskQueueBase*> worker_queue);
// TODO: bugs.webrtc.org/14169 - Delete this variant when no longer used by
// chromium.
static absl::Nullable<std::unique_ptr<AecDump>> Create(
absl::Nonnull<FILE*> handle,
int64_t max_log_size_bytes,
absl::Nonnull<rtc::TaskQueue*> worker_queue) {
return Create(handle, max_log_size_bytes, worker_queue->Get());
}
}; };
} // namespace webrtc } // namespace webrtc

15
modules/audio_processing/include/audio_processing.cc
View File

@ -12,7 +12,6 @@
#include "rtc_base/strings/string_builder.h" #include "rtc_base/strings/string_builder.h"
#include "rtc_base/system/arch.h" #include "rtc_base/system/arch.h"
#include "rtc_base/task_queue.h"
namespace webrtc { namespace webrtc {
namespace { namespace {
@ -208,18 +207,4 @@ std::string AudioProcessing::Config::ToString() const {
return builder.str(); return builder.str();
} }
bool AudioProcessing::CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(file_name, max_log_size_bytes,
worker_queue->Get());
}
bool AudioProcessing::CreateAndAttachAecDump(FILE* handle,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue) {
return CreateAndAttachAecDump(handle, max_log_size_bytes,
worker_queue->Get());
}
} // namespace webrtc } // namespace webrtc

12
modules/audio_processing/include/audio_processing.h
View File

@ -37,10 +37,6 @@
#include "rtc_base/system/file_wrapper.h" #include "rtc_base/system/file_wrapper.h"
#include "rtc_base/system/rtc_export.h" #include "rtc_base/system/rtc_export.h"
namespace rtc {
class TaskQueue;
} // namespace rtc
namespace webrtc { namespace webrtc {
class AecDump; class AecDump;
@ -634,14 +630,6 @@ class RTC_EXPORT AudioProcessing : public RefCountInterface {
// return value of true indicates that the file has been // return value of true indicates that the file has been
// sucessfully opened, while a value of false indicates that // sucessfully opened, while a value of false indicates that
// opening the file failed. // opening the file failed.
// TODO: bugs.webrtc.org/14169 - Delete rtc::TaskQueue variants
[[deprecated]] bool CreateAndAttachAecDump(absl::string_view file_name,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue);
[[deprecated]] bool CreateAndAttachAecDump(FILE* handle,
int64_t max_log_size_bytes,
rtc::TaskQueue* worker_queue);
virtual bool CreateAndAttachAecDump( virtual bool CreateAndAttachAecDump(
absl::string_view file_name, absl::string_view file_name,
int64_t max_log_size_bytes, int64_t max_log_size_bytes,