From 0240cf8625a989ec51cc3bf749ed587440f2aeaa Mon Sep 17 00:00:00 2001 From: Philipp Hancke Date: Mon, 7 Sep 2020 22:13:42 +0200 Subject: [PATCH] stop sending x-peer-id in peerconnection_server the comment about why that is not a thing dates from 2013. BUG=None Change-Id: I97ec5090fc1acb4361bc8472fe605dafea89aa1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183545 Reviewed-by: Tommi Commit-Queue: Philipp Hancke Cr-Commit-Position: refs/heads/master@{#32267} --- examples/peerconnection/client/peer_connection_client.cc | 3 +-- examples/peerconnection/server/data_socket.cc | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/peerconnection/client/peer_connection_client.cc b/examples/peerconnection/client/peer_connection_client.cc index b458927095..9bf2a0fecc 100644 --- a/examples/peerconnection/client/peer_connection_client.cc +++ b/examples/peerconnection/client/peer_connection_client.cc @@ -465,8 +465,7 @@ bool PeerConnectionClient::ParseServerResponse(const std::string& response, *peer_id = -1; - // See comment in peer_channel.cc for why we use the Pragma header and - // not e.g. "X-Peer-Id". + // See comment in peer_channel.cc for why we use the Pragma header. GetHeaderValue(response, *eoh, "\r\nPragma: ", peer_id); return true; diff --git a/examples/peerconnection/server/data_socket.cc b/examples/peerconnection/server/data_socket.cc index 2b625b079a..ced0fd1bae 100644 --- a/examples/peerconnection/server/data_socket.cc +++ b/examples/peerconnection/server/data_socket.cc @@ -31,7 +31,7 @@ const char DataSocket::kCrossOriginAllowHeaders[] = "Access-Control-Allow-Methods: POST, GET, OPTIONS\r\n" "Access-Control-Allow-Headers: Content-Type, " "Content-Length, Connection, Cache-Control\r\n" - "Access-Control-Expose-Headers: Content-Length, X-Peer-Id\r\n"; + "Access-Control-Expose-Headers: Content-Length\r\n"; #if defined(WIN32) class WinsockInitializer {