From 01fe3098030d87342cd9428cbdda7157d100dbe6 Mon Sep 17 00:00:00 2001 From: "Piotr (Peter) Slatala" Date: Fri, 15 Feb 2019 12:05:50 -0800 Subject: [PATCH] Do not use RtcEventLogs in media transport when used only for data channel. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is possible to get event logs from both RTP and MediaTransport when media transport is only used for data channel. This is undesirable. We would rather not get any logs from media transport when it's not used for media. This change disables rtc event log when media transport is not used for media. Bug: webrtc:9719 Change-Id: Ibc660b37c5d98001144e5f68b32f0608fd6ede33 Reviewed-on: https://webrtc-review.googlesource.com/c/123260 Commit-Queue: Peter Slatala Reviewed-by: Björn Terelius Reviewed-by: Steve Anton Reviewed-by: Bjorn Mellem Cr-Commit-Position: refs/heads/master@{#26776} --- pc/jsep_transport_controller.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pc/jsep_transport_controller.cc b/pc/jsep_transport_controller.cc index 7020c6cbb7..eb78f3473a 100644 --- a/pc/jsep_transport_controller.cc +++ b/pc/jsep_transport_controller.cc @@ -1039,7 +1039,9 @@ JsepTransportController::MaybeCreateMediaTransport( settings.is_caller = local; settings.pre_shared_key = std::string( reinterpret_cast(key.value().data()), key.value().size()); - settings.event_log = config_.event_log; + if (config_.use_media_transport_for_media) { + settings.event_log = config_.event_log; + } auto media_transport_result = config_.media_transport_factory->CreateMediaTransport( ice_transport, network_thread_, settings);