admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Faster erase buffer within FrameCombiner with -Oz opt level.

Browse Source 
Previous erase implementation on clang with -Oz optimization
leve produced effectively per element zeroing, causing
unnecessary CPU usage on mobiles.
Using zero-initialization is both shorter and easier to
optimize for clang:
https://en.cppreference.com/w/cpp/language/zero_initialization
Godbolt links with example of codegen:
Before: https://godbolt.org/z/feT3bfoxr
After: https://godbolt.org/z/PTra3sfoz

Bug: None
Change-Id: Ie1eae3455ded42e2b65fdb15436d8698277f6504
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281400
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38547}
This commit is contained in:
Yura Yaroshevich 2022-11-01 21:20:52 +01:00 committed by WebRTC LUCI CQ
parent bab259a023
commit 01c2c325bd
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/audio_mixer/frame_combiner.cc
View File

@ -98,9 +98,7 @@ void MixToFloatFrame(rtc::ArrayView<const AudioFrame* const> mix_list,
RTC_DCHECK_LE(samples_per_channel, FrameCombiner::kMaximumChannelSize);
RTC_DCHECK_LE(number_of_channels, FrameCombiner::kMaximumNumberOfChannels);
// Clear the mixing buffer.
for (auto& one_channel_buffer : *mixing_buffer) {
std::fill(one_channel_buffer.begin(), one_channel_buffer.end(), 0.f);
}
*mixing_buffer = {};
// Convert to FloatS16 and mix.
for (size_t i = 0; i < mix_list.size(); ++i) {