From 00a810b844b2393b64f7e36ce1524dd9e3dccb4b Mon Sep 17 00:00:00 2001 From: mbonadei Date: Wed, 21 Dec 2016 02:01:26 -0800 Subject: [PATCH] Refactor webrtc/modules/video_processing for GN check This moves some GN check configurations out of .gn to individual targets. The now checked target is: "//webrtc/modules/video_processing/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2595543002 Cr-Commit-Position: refs/heads/master@{#15732} --- .gn | 1 + webrtc/modules/video_processing/BUILD.gn | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/.gn b/.gn index 961190dbc1..40a182fbb6 100644 --- a/.gn +++ b/.gn @@ -33,6 +33,7 @@ check_targets = [ "//webrtc/modules/pacing/*", "//webrtc/modules/video_capture/*", "//webrtc/modules/video_coding/*", + "//webrtc/modules/video_processing/*", "//webrtc/stats:rtc_stats", "//webrtc/voice_engine", "//webrtc/voice_engine:level_indicator", diff --git a/webrtc/modules/video_processing/BUILD.gn b/webrtc/modules/video_processing/BUILD.gn index b1ab8ecc5e..d4faf2592a 100644 --- a/webrtc/modules/video_processing/BUILD.gn +++ b/webrtc/modules/video_processing/BUILD.gn @@ -26,6 +26,7 @@ rtc_static_library("video_processing") { ] deps = [ + "../../base:rtc_base_approved", "../../common_audio", "../../common_video", "../../modules/utility", @@ -46,11 +47,20 @@ rtc_static_library("video_processing") { if (build_video_processing_sse2) { rtc_static_library("video_processing_sse2") { + # TODO(mbonadei): Remove (bugs.webrtc.org/6828) + # Errors on cyclic dependency with :video_processing if enabled. + check_includes = false + sources = [ "util/denoiser_filter_sse2.cc", "util/denoiser_filter_sse2.h", ] + deps = [ + "../../base:rtc_base_approved", + "../../system_wrappers", + ] + if (!build_with_chromium && is_clang) { # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]